Remove kusama and polkadot SP constants from parachains-common (#2666)

paritytech · Jan 4, 2024 · 6f9b1f6 · 6f9b1f6
1 parent b0a8746
commit 6f9b1f6
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 270 deletions.
diff --git a/cumulus/parachains/common/src/kusama.rs b/cumulus/parachains/common/src/kusama.rs
diff --git a/cumulus/parachains/common/src/lib.rs b/cumulus/parachains/common/src/lib.rs
@@ -16,9 +16,7 @@
 #![cfg_attr(not(feature = "std"), no_std)]
 
 pub mod impls;
-pub mod kusama;
 pub mod message_queue;
-pub mod polkadot;
 pub mod rococo;
 pub mod westend;
 pub mod wococo;

diff --git a/cumulus/parachains/common/src/polkadot.rs b/cumulus/parachains/common/src/polkadot.rs
diff --git a/cumulus/parachains/runtimes/people/people-rococo/src/people.rs b/cumulus/parachains/runtimes/people/people-rococo/src/people.rs
@@ -36,7 +36,7 @@ parameter_types! {
 	pub const ByteDeposit: Balance = deposit(0, 1);
 	pub const SubAccountDeposit: Balance = deposit(1, 53);
 	pub RelayTreasuryAccount: AccountId =
-		parachains_common::polkadot::account::POLKADOT_TREASURY_PALLET_ID.into_account_truncating();
+		parachains_common::TREASURY_PALLET_ID.into_account_truncating();
 }
 
 impl pallet_identity::Config for Runtime {

diff --git a/cumulus/parachains/runtimes/people/people-westend/src/people.rs b/cumulus/parachains/runtimes/people/people-westend/src/people.rs
@@ -36,7 +36,7 @@ parameter_types! {
 	pub const ByteDeposit: Balance = deposit(0, 1);
 	pub const SubAccountDeposit: Balance = deposit(1, 53);
 	pub RelayTreasuryAccount: AccountId =
-		parachains_common::polkadot::account::POLKADOT_TREASURY_PALLET_ID.into_account_truncating();
+		parachains_common::TREASURY_PALLET_ID.into_account_truncating();
 }
 
 impl pallet_identity::Config for Runtime {

diff --git a/prdoc/pr_2666.prdoc b/prdoc/pr_2666.prdoc
@@ -0,0 +1,14 @@
+# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
+# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json
+
+title: Remove kusama and polkadot SP constants from parachains-common
+
+doc:
+  - audience: Runtime Dev
+    description: |
+      The constants for System Parachains in Kusama and Polkadot are now added to a new package in
+      the fellowship repo. This PR removes them from Polkadot-SDK. They are now accessible from the
+      `system-parachains-constants` package.
+
+crates:
+  - name: parachains-common