-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove unused code in staking-async #10842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sigurpol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth backporting to 2512 as well to simplify following staking PRs backporting (e.g. DAP satellite, session keys etc) for 2512 since this will be probably merged first. @kianenigma wdyt?
|
Sure can do! |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd prdoc generate --bump major |
|
/cmd prdoc --bump major |
| - rename `ahm-test` to `integration-tests` | ||
| crates: | ||
| - name: polkadot-sdk | ||
| bump: major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had some annoyance recently while backporting PRs with major changes that ended up not being strictly major in reality... I guess we might end up backporting this PR as well if we merge it before the pending DAP stuff for phase 1 since it probably makes merging easier and it's no risk. My question here is : do we feel that the removal of reward-fn without public API or anything is really a major change?
reward-fnfrompallet-staking-async. This crate is no longer needed.ahm-testtointegration-tests