Skip to content

Conversation

@kianenigma
Copy link
Contributor

  • remove the reward-fn from pallet-staking-async. This crate is no longer needed.
  • rename ahm-test to integration-tests

@kianenigma kianenigma requested a review from a team as a code owner January 19, 2026 14:30
@kianenigma kianenigma added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jan 19, 2026
Copy link
Contributor

@sigurpol sigurpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth backporting to 2512 as well to simplify following staking PRs backporting (e.g. DAP satellite, session keys etc) for 2512 since this will be probably merged first. @kianenigma wdyt?

@kianenigma kianenigma added the A4-backport-stable2512 Pull request must be backported to the stable2512 release branch label Jan 22, 2026
@kianenigma
Copy link
Contributor Author

Sure can do!

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501414
Failed job name: test-linux-stable-runtime-benchmarks

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501427
Failed job name: check-runtime-migration

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501414
Failed job name: test-linux-stable

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501427
Failed job name: check-runtime-migration

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501597
Failed job name: build-templates-node

@kianenigma
Copy link
Contributor Author

/cmd prdoc generate --bump major

@kianenigma
Copy link
Contributor Author

/cmd prdoc --bump major

- rename `ahm-test` to `integration-tests`
crates:
- name: polkadot-sdk
bump: major
Copy link
Contributor

@sigurpol sigurpol Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had some annoyance recently while backporting PRs with major changes that ended up not being strictly major in reality... I guess we might end up backporting this PR as well if we merge it before the pending DAP stuff for phase 1 since it probably makes merging easier and it's no risk. My question here is : do we feel that the removal of reward-fn without public API or anything is really a major change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2512 Pull request must be backported to the stable2512 release branch R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants