-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WIP] Move era reward minting to DAP with era-based allocation in Staking #10844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ank4n
wants to merge
42
commits into
master
Choose a base branch
from
ankn-dap-rewire
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,808
−344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements: https://hackmd.io/@jonasW3F/rkN6BXE2ex
Overview
This PR moves era reward minting logic from
pallet-staking-asynctopallet-dapas well as introducing budget allocation management to DAP. Closing #10833 in favour of this since the era pot management belongs to staking.Changes
Functional
StakingRewardProvidertrait instead of minting on-the-flyTraits
StakingRewardProvider: Enables staking to request era reward allocation (minting + funding pots).UnclaimedRewardSink: Specifies destination for unclaimed rewards when era pots are cleaned up after history depth expires.EraPayoutV2: SucceedsEraPayoutreturning single era emission value (instead of tuple of (staking, treasury) split) that DAP can budget internally.Non-Changes
Runtime Integration
Runtimes need to make the following changes:
EraPayoutV2implementation topallet-dap::Configstaking_async::Config::EraPayoutwithRewardProvider = DapOut of Scope
TODO