-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Upgrade litep2p to v0.13.0 #10859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade litep2p to v0.13.0 #10859
Conversation
| - name: sc-network | ||
| bump: major | ||
| - name: sc-network-types | ||
| bump: major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitry-markin both are majors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semver check thinks so.
lexnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job here! I would backport this on 2509 and 2512 as well, since it contains some extra fixes for stability which might improve collator protocols 🙏
cc #10425
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10859-to-stable2509
git worktree add --checkout .worktree/backport-10859-to-stable2509 backport-10859-to-stable2509
cd .worktree/backport-10859-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 0a386503ab5d3f77d30031e539640c89b254b492
git push --force-with-lease |
This PR upgrades litep2p to the latest version, bringing multiple fixes with this release. Specifically, this release enhances WebSocket stability by resolving `AsyncWrite` errors and ensuring that partial writes during the negotiation phase no longer trigger connection failures. It also fixes large file download using Bitswap protocol by grouping blocks into batches of <= 2 MiB. (cherry picked from commit 0a38650)
|
Successfully created backport PR for |
Backport #10859 into `stable2512` from dmitry-markin. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Egor_P <egor@parity.io>
This PR upgrades litep2p to the latest version, bringing multiple fixes with this release.
Specifically, this release enhances WebSocket stability by resolving
AsyncWriteerrors and ensuring that partial writes during the negotiation phase no longer trigger connection failures.It also fixes large file download using Bitswap protocol by grouping blocks into batches of <= 2 MiB.