[WIP][pallet-assets] add ForeignAssetIdExtractor to assets precompile #10869
+683
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc1b49d.
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
0xRVE
changed the title
…ch/polkadot-sdk into rve/8659-assets-precompile
acatangiu
reviewed
Jan 22, 2026
Contributor
|
Another general comment is that it needs more tests (easy to use Claude for writing tests fast). |
0xRVE
force-pushed
the
rve/8659-assets-precompile
branch
from
27ff790 to
06b9f65
Compare
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
Author
done |
acatangiu
approved these changes
Jan 23, 2026
| Revive: pallet_revive = 60, | ||
|
|
||
| AssetRewards: pallet_asset_rewards = 61, | ||
| ForeignAssetsPrecompiles: pallet_assets_precompiles::pallet = 62, |
Contributor
There was a problem hiding this comment.
Suggested change
| ForeignAssetsPrecompiles: pallet_assets_precompiles::pallet = 62, | |
| AssetsPrecompiles: pallet_assets_precompiles::pallet = 62, |
| asset_index, | ||
| )); | ||
|
|
||
| println!("asset_addr: {:?}", asset_addr); |
Contributor
There was a problem hiding this comment.
use tracing or log instead of println even in tests
Suggested change
| println!("asset_addr: {:?}", asset_addr); | |
| tracing::info!("asset_addr: {:?}", asset_addr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8659
Adds ForeignAssetIdExtractor which converts a u32 asset id to an XCM Location type.