[pallet-revive] bump resolc #10873
[pallet-revive] bump resolc #10873
Conversation
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
|
|
||
| - name: Install resolc | ||
| run: | | ||
| VERSION="0.3.0" |
There was a problem hiding this comment.
@xermicus @pgherveou
Why was this still 0.3.0?
|
@0xRVE The differential tests CI for PolkaVM fail since the expectations file we have in the repo says that X set tests should fail but with this version of the compiler Y set of tests now fail. To make CI pass you should check the CI job, find the expectations file for PolkaVM, then update the one used in the repo. You can find the expectation file in the workflow summary here: https://github.com/paritytech/polkadot-sdk/actions/runs/21245356379?pr=10873 |
| cargo-command: "forklift cargo" | ||
| revive-differential-tests-ref: "be448d78bd83a755fdcab96849971ecdf4eebce0" | ||
| resolc-version: "0.5.0" | ||
| resolc-version: "0.6.0" |
There was a problem hiding this comment.
do we need that here at all for evm?
There was a problem hiding this comment.
We don't need it for the EVM, but it makes the action simpler
There was a problem hiding this comment.
After a discussion else-where, the test suite seems to assert on hardcoded expectations or values collected from an outdated version of the pallet and compiler.
bump resolc version to 0.6.0 in github workflows