-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove failing assertion related to VoterList count mismatch #10880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d51249c
remove invalid voter count assertion due to PendingRebag
cirko33 5069946
Merge branch 'master' into cirko33-10687-bug
cirko33 17d1d36
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] 9b4583b
log instead of commenting out
cirko33 21e3c1c
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] 9f90bb0
log instead of assert
cirko33 98bf01d
fix bags list error throwing & tests
cirko33 1af6923
test vote & nomination in pendingrebag
cirko33 35d470f
update prdoc
cirko33 c1aae5e
Merge branch 'master' into cirko33-10687-bug
cirko33 bdab080
fmt
cirko33 572c988
fix formatting
cirko33 dc8285d
fix: propagate try-runtime feature to pallet-bags-list
cirko33 cd4ddc9
fix formatting with taplo
cirko33 ebeee68
update for semver change
cirko33 8c3aa43
Merge branch 'master' into cirko33-10687-bug
cirko33 484370c
Merge branch 'master' into cirko33-10687-bug
cirko33 c8c6ccf
cleaner coding style
cirko33 10b86a0
remove test & fix formatting
cirko33 d6af14c
update revert to not show diff
cirko33 58ee370
fix formatting again
cirko33 ee1e41b
remove test
cirko33 2380393
Merge branch 'master' into cirko33-10687-bug
cirko33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| title: remove invalid voter count assertion due to PendingRebag | ||
| doc: | ||
| - audience: Runtime Dev | ||
| description: |- | ||
| Refers to: #10687 | ||
|
|
||
| This PR comments out the section where the error occurs due to the implementation of `PendingRebag` (#9725). This change resolves the issue but may lead to a misalignment where the VoterList count no longer matches the sum of Nominations and Validators. | ||
| crates: | ||
| - name: pallet-staking-async | ||
| bump: patch | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.