collator-protocol: Re-advertise collations when peer authority IDs are updated #10891
+226
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collator protocol contained a race-condition which could manifest as "Collation wasn't advertised".
A given peer ("A") can connect before the new authority keys are received via
UpdatedAuthorityIds(nk -- new key).PeerConnectedPeerViewChangevalidator_group.should_advertise_to: checks peer A for key nK (the new key)ShouldAdvertiseTo::NotAuthorityUpdatedAuthorityIdsarrives with (peer A, [nK])At this point, we have the collation, peer A wants to collation, we know peer A is an authority but we never send the collation back. Then, the collation will expire with "Collation wasn't advertised".
To close the gap, the
UpdatedAuthorityIdsevents will trigger a re-advertisement of collationsPart of the stabilization of: