txpool: fix: instant-seal stall when resubmit re-imports as ready#12073
Draft
mokita-j wants to merge 4 commits into
Draft
txpool: fix: instant-seal stall when resubmit re-imports as ready#12073mokita-j wants to merge 4 commits into
mokita-j wants to merge 4 commits into
Conversation
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: a transaction that reaches
Readyonly throughresubmit(e.g. one the proposer left over after aHitBlockWeightLimitblock and the periodic revalidation worker re-imported) fires no notification, so the seal engine stays parked and the chain stalls with a ready transaction in the pool.Fix: notify
import_notification_sinksfrom theresubmitpath when a transaction re-imports asImported::Ready, just like the submit path does.Affects
revive-dev-nodein default--consensus instant-sealand other nodes usingrun_instant_seal*.