Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) #7003

Merged
merged 80 commits into from
Feb 21, 2025
Merged

xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) #7003

merged 80 commits into from
Feb 21, 2025
+478 −341

Conversation

ayevbeosa
Copy link
Contributor

@ayevbeosa ayevbeosa commented Dec 26, 2024 •
edited
Loading

Description

Added logs in pallet-xcm to help in debugging, fixes #2408, and in continuation of #4982

Checklist

Polkadot Address: 1Gz5aLtEu2n4jsfA6XwtZnuaRymJrDDw4kEGdNHTdxrpzrc

@ayevbeosa ayevbeosa changed the title pallet-xcm: added logging for xcm filters/helpers/matchers/types (#2408) xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) Dec 26, 2024
@ayevbeosa ayevbeosa marked this pull request as ready for review December 27, 2024 05:43
@ayevbeosa ayevbeosa requested a review from a team as a code owner December 27, 2024 05:43
bkchr
bkchr reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change all these calls to follow the same pattern as shown by me in teh suggestions?

ayevbeosa and others added 8 commits December 27, 2024 15:29
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/fungible_convers…
b4bf289 
…ion.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/benchmarks.rs
61c41ed 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/benchmarks.rs
74ba6cc 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/matching.rs
5548e1e 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa
Merge branch 'master' into ayevbeosa-more-xcm-logs
e2cc86c
Merge branch 'ayevbeosa-more-xcm-logs' of https://github.com/ayevbeos…
e9d8c5e 
…a/polkadot-sdk into ayevbeosa-more-xcm-logs
changed tracing call pattern
d32edd7
@ayevbeosa
Merge branch 'master' into ayevbeosa-more-xcm-logs
fcdda09
@raymondkfcheung raymondkfcheung mentioned this pull request Feb 20, 2025
Closed
@raymondkfcheung
Copy link
Contributor

@ayevbeosa raised a fix: ayevbeosa#1

@raymondkfcheung raymondkfcheung mentioned this pull request Feb 20, 2025
Open
24 tasks
@acatangiu
Copy link
Contributor

@ayevbeosa please merge ayevbeosa#1 to your branch as it brings the missing pieces.

Also feel free to add your Polkadot address to this PR's description so we can propose an on-chain tip 👍

@raymondkfcheung
Copy link
Contributor

/cmd fmt

@ayevbeosa
Copy link
Contributor Author

@ayevbeosa please merge ayevbeosa#1 to your branch as it brings the missing pieces.

Also feel free to add your Polkadot address to this PR's description so we can propose an on-chain tip 👍

Apologies for my delayed response, I have been having issues with my laptop.

@raymondkfcheung
Copy link
Contributor

Apologies for my delayed response, I have been having issues with my laptop.

No worries, I merged it. Thanks.

@ayevbeosa
Copy link
Contributor Author

Apologies for my delayed response, I have been having issues with my laptop.

No worries, I merged it. Thanks.

Thanks for the help 🙏

acatangiu
acatangiu approved these changes Feb 21, 2025
View reviewed changes
@acatangiu acatangiu enabled auto-merge February 21, 2025 14:41
@acatangiu
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@acatangiu A referendum for a small (20 DOT) tip was successfully submitted for @ayevbeosa (1Gz5aLtEu2n4jsfA6XwtZnuaRymJrDDw4kEGdNHTdxrpzrc on polkadot).

Referendum number: 1451.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@raymondkfcheung
Copy link
Contributor

/cmd fmt

@acatangiu acatangiu added this pull request to the merge queue Feb 21, 2025
Merged via the queue into paritytech:master with commit 934c091 Feb 21, 2025
237 of 254 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

@raymondkfcheung raymondkfcheung raymondkfcheung approved these changes

Assignees

@raymondkfcheung raymondkfcheung

Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XCM] don't ignore errors
4 participants
@ayevbeosa @bkchr @raymondkfcheung @acatangiu