-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add view functions to Proxy pallet for runtime-specific type configuration #7297 #7320
Conversation
Please review @bkchr |
Please review @bkchr |
As @kianenigma requested in #7297 (comment) I updated the implementation by adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the lock files need to be updated?
The idea of view functions is to be a stable interface as well. The two functions added here seem pretty reasonable to me, but good for other reviewers to also double check that.
Review required! Latest push from author must always be reviewed |
I think it was because I updated cargo
|
/cmd prdoc --audience runtime_dev --bump minor |
Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here |
@bkchr Do I need to add a prdoc file? |
/cmd prdoc --bump minor --audience runtime_user |
Command "prdoc --bump minor --audience runtime_user" has failed ❌! See logs here |
/cmd prdoc --bump minor --audience runtime_user |
Command "prdoc --bump minor --audience runtime_user" has failed ❌! See logs here |
Yes. |
Head branch was pushed to by a user without write access
87ac3f2
Glad to see this merged🎉 please see my Polkadot address in the description @bkchr |
/tip small |
@bkchr A referendum for a small (20 DOT) tip was successfully submitted for @Nathy-bajo (121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1 on polkadot). |
The referendum has appeared on Polkassembly. |
…ation paritytech#7297 (paritytech#7320) Solves paritytech#7297 I added a ProxyApi runtime API to the Proxy pallet with two methods: check_permissions: Checks if a RuntimeCall passes a ProxyType's InstanceFilter. is_superset: Verifies if one ProxyType includes another. Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Solves #7297
I added a ProxyApi runtime API to the Proxy pallet with two methods:
check_permissions: Checks if a RuntimeCall passes a ProxyType's InstanceFilter.
is_superset: Verifies if one ProxyType includes another.
Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1