Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up for: Use the umbrella crate for the parachain template #5993 #7464
base: master
Are you sure you want to change the base?
Follow up for: Use the umbrella crate for the parachain template #5993 #7464
Changes from 10 commits
458f1d0
a7eafd4
1b4dadf
31c7872
5a107ef
60a91c2
64a49ad
397a818
a889bbc
9ae57ca
b2c016a
e15c49d
ec70c2e
8a09b44
38c3dcc
a62bced
afcd41f
db8ca90
e20a4f1
718604e
ab2822e
8310ca2
3ef39b8
0ae2a6c
02d57d5
1c69a34
f0f65c8
3f36de3
ad6e74a
4ad0f0a
2f95de5
c7a07b9
ac9c846
5166954
e2f570d
52e0448
13142f1
41f6258
7cf4e92
41a860e
60f3a6a
1ed9c36
c93ad26
5391802
00c3bfa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sc-*
crates are Substrate Client libraries, they should not be in the runtime feature.Please use the
generate-umbrella.py
script if you want to update it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok makes sense, was just trying an experiment, i will keep that in mind, thanks