-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add genesis presets for glutton westend #7481
base: master
Are you sure you want to change the base?
add genesis presets for glutton westend #7481
Conversation
/cmd prdoc --audience runtime_dev --bump minor |
cumulus/parachains/runtimes/glutton/glutton-westend/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clangenb also please clean cumulus/polkadot-parchain/src/chain_spec/glutton.rs
Hmm, I don't think this is a good idea, polkadot-parachain-bin CLI wants to extract the para-id from the command, see
But we can't do this with the genesis presets, as the para-id is hardcoded. So I think I should only clean this up, if we decide to remove the option for passing custom para-ids from the CLI. What is your take on this? |
…s_config_presets.rs Co-authored-by: Branislav Kontur <[email protected]>
I see, so you don't need to use
at least we will use one source of this genesis, and it should be ok, while we are referencing the |
Ahh, damn you are right. I could have thought of this too. Thanks. 🚀 |
/cmd prdoc --audience runtime_dev --bump minor |
Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here |
/cmd prdoc --audience runtime_dev --bump minor --force |
…bump minor --force'
PR is ready for more reviews. 🚀 |
Extracted from #7473.
Part of: #5704.
I did not use the genesis presets in the parachain-bin, as we rely on passing custom para-ids to the chains specs to launch many glutton chains on one relay chain (is this still true?). This is currently not compatible with the genesis presets, which hard code the para ID, see #7618 and #7384.
However, the parachain-bin genesis config for glutton at least refers to the one from the runtime to prevent duplication.