Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rpc_port in bridge tests #7520

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Use rpc_port in bridge tests #7520

merged 2 commits into from
Feb 10, 2025

Conversation

serban300
Copy link
Contributor

Use rpc_port instead of ws_port in bridge tests since ws_port is deprecated.

@serban300 serban300 added T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges. labels Feb 10, 2025
@serban300 serban300 self-assigned this Feb 10, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 10, 2025 12:43
@serban300 serban300 added the R0-silent Changes should not be mentioned in any release notes label Feb 10, 2025
@acatangiu
Copy link
Contributor

acatangiu commented Feb 10, 2025 •
edited
Loading

need the same for fellowship/runtimes zombienet test

@serban300
Copy link
Contributor Author

need the same for fellowship/runtimes zombienet test

Yes, will do. Just waiting to make sure the tests pass.

@serban300 serban300 requested a review from a team as a code owner February 10, 2025 13:13
@serban300 serban300 added this pull request to the merge queue Feb 10, 2025
@serban300 serban300 removed this pull request from the merge queue due to a manual request Feb 10, 2025
@serban300
Copy link
Contributor Author

@pepoviola also had to update the zombienet image to v1.3.120 . Just wanted to check if you have any concern related to this

@pepoviola
Copy link
Contributor

@pepoviola also had to update the zombienet image to v1.3.120 . Just wanted to check if you have any concern related to this

No, should works as expected. Thanks!!

@serban300 serban300 added this pull request to the merge queue Feb 10, 2025
Merged via the queue into paritytech:master with commit 71c19e4 Feb 10, 2025
210 of 217 checks passed
@serban300 serban300 deleted the small_fixes branch February 10, 2025 20:30
@serban300
Copy link
Contributor Author

need the same for fellowship/runtimes zombienet test

Yes, will do. Just waiting to make sure the tests pass.

Opened a PR in femmowship/runtimes: polkadot-fellows/runtimes#588

clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request Feb 19, 2025
@serban300 @clangenb
Use rpc_port in bridge tests (paritytech#7520)
fa98d3d 
Use `rpc_port` instead of `ws_port` in bridge tests since `ws_port` is
deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@bkontur bkontur bkontur approved these changes

@acatangiu acatangiu acatangiu approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees

@serban300 serban300

Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serban300 @acatangiu @pepoviola @bkontur @alvicsam