runtime-api: remove redundant version checks #7610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw10pa
added
T4-runtime_API
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
reviewed
Feb 18, 2025
| } | ||
|
|
||
| /// Request the node features enabled in the runtime. | ||
| /// Pass in the session index for caching purposes, as it should only change on session boundaries. | ||
| /// Prior to runtime API version 9, just return `None`. | ||
| pub async fn request_node_features( | ||
| parent: Hash, | ||
| session_index: SessionIndex, | ||
| sender: &mut impl overseer::SubsystemSender<RuntimeApiMessage>, | ||
| ) -> Result<Option<NodeFeatures>> { |
There was a problem hiding this comment.
This now always returns Some, so you can remove the Option.
alindima
reviewed
Feb 19, 2025
| @@ -469,61 +469,35 @@ where | |||
| } | |||
|
|
|||
| /// Request the min backing votes value. | |||
| /// Prior to runtime API version 6, just return a hardcoded constant. | |||
| pub async fn request_min_backing_votes( | |||
There was a problem hiding this comment.
we can remove these helpers altogether and implement them with specialize_requests like we do for the other runtime APIs
tdimitrov
reviewed
Feb 19, 2025
| let disabled_validators = get_disabled_validators_with_fallback(sender, parent) | ||
| .await | ||
| .map_err(|e| Error::try_from(e).expect("the conversion is infallible; qed"))?; | ||
| let disabled_validators = request_disabled_validators(parent, sender).await.await??; |
There was a problem hiding this comment.
nit: You can move request_disabled_validators call to the try_join above for consistency (like it's done for validators).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
MinimumBackingVotesandNodeFeatures, that are already supported by Polkadot.Description
This PR removes unnecessary runtime API version checks from
subsystem-util/src/runtimefor APIs supported by Polkadot (the most recent network to upgrade). Specifically, it applies to theDisabledValidators,MinimumBackingVotesandNodeFeaturesAPIs.