Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pallet-revive] Remove js examples #7660

Merged
merged 4 commits into from
Feb 21, 2025
Merged

[pallet-revive] Remove js examples #7660

merged 4 commits into from
Feb 21, 2025

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Feb 21, 2025

Remove JS examples, they now belongs to the evm-test-suite repo

They now belongs to the evm-test-suite
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Feb 21, 2025
@athei
Copy link
Member

athei commented Feb 21, 2025

Can you move the examples outside of the rust directory now to follow cargo conventions? Then we also don't need to explicitly mention them in the manifest anymore.

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13456559509
Failed job name: cargo-clippy

@pgherveou pgherveou enabled auto-merge February 21, 2025 12:57
@pgherveou pgherveou added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit e915cad Feb 21, 2025
247 of 256 checks passed
@pgherveou pgherveou deleted the pg/rm-js-examples branch February 21, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants