Fix: [Referenda Tracks] Resolve representation issues that are breaking PJS apps #7671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2025
pandres95
force-pushed
the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
from
6fe1641 to
f7f6920
Compare
…y like a string change(pallet-referenda): create const function that helps construct `StringLike` to reduce changes in tracks definitions fix: fmt
pandres95
force-pushed
the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
from
e8538fe to
44b58c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the following issues present with PJS derived from #2072
Tracksconstant as aVec<(TrackId, TrackInfo)>instead ofVec<Track>, so tracks iteration in PJS apps Governance hook remains as how it was before, and[u8; N]fromnamefield in aStringLikestructure that represents itsTypeInfoas a&strand encodes as such. This fixes errors present in PJS apps that treatnameas a javascriptstring.