Fix and test sr25519 signing in nostd #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this working in wasm |
niklasad1
reviewed
Nov 25, 2024
niklasad1
reviewed
Nov 25, 2024
| @@ -66,7 +66,7 @@ hmac = { workspace = true } | |||
| zeroize = { workspace = true } | |||
| bip39 = { workspace = true } | |||
| bip32 = { workspace = true, features = ["alloc", "secp256k1"], optional = true } | |||
| schnorrkel = { workspace = true, optional = true } | |||
| schnorrkel = { workspace = true, optional = true, features = ["getrandom"] } | |||
There was a problem hiding this comment.
perhaps update the README in the signer crate that "sr25519 needs getrandom" which isn't supported on all platforms
There was a problem hiding this comment.
can we remove the getrandom feature flag now below?
There was a problem hiding this comment.
I don't believe so because we have web = ["getrandom/js"] to enable the relevant getrandom feature if compiling for the web.
(There's a separate conversation around whether this should be a thing of whether to make downstream consumers enable said feature flag instead, which is what getrandom suggests IIRC)
niklasad1
reviewed
Nov 25, 2024
niklasad1
reviewed
Nov 25, 2024
lexnv
approved these changes
Nov 25, 2024
jsdw
force-pushed
the
jsdw-signer-nostd-fix
branch
from
826410c to
8dd4d1b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had WASM tests for signing things, but no nostd tests. Adding them shows an issue signing via sr25519 (reported in #1871), for which adding the
getrandomfeature to schnorrkel seems to fix (pending CI passing here).I had to remove some code in
testing/no-std-testsbecause signing with sr25519 isn't supported on thethumbv7em-none-eabitarget we run the nostd tests on. Previously it would compile OK because we didn't enable thegetrandomfeature, but I think if we were able to run it, we'd have seen a runtime error instead. Some other nostd targets probably handle this all OK (getrandomhas a list here: https://docs.rs/getrandom/latest/getrandom/#unsupported-targets)