-
-
Notifications
You must be signed in to change notification settings - Fork 595
feat: Allow logout with invalid session token #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Hi all, Not sure if my formatting is perfect but closes parse-community#1176 (removes pre. SDK 2.0 success functions), and adds documentation for LiveQuery triggers. Also, for me, when I google "Parse Javascript SDK", it takes me to v1.11.0. Is there any way we can add "This SDK is outdated" or some other warning to point users to the latest SDK? Thank you!
Update Cloud Code
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #1803 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6238 6244 +6
Branches 1450 1467 +17
=========================================
+ Hits 6238 6244 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What would be the difference between the first and second logout request? What makes the first fail and the second succeed? |
@dblythy Friendly ping regarding the previous question. If the 1st logout attempt fails, why does the 2nd attempt (after catching the error) succeed? |
@dblythy We should add this to the server side like parse-community/parse-server#8722 so that it can work for all SDK's @mtrezza I have no idea why there is a need to call |
Could you please open a separate issue for this? |
are we still tracking this? |
@dblythy Nice job! Can you fix the merge conflicts? |
@@ -812,11 +812,13 @@ class ParseUser<T extends Attributes = Attributes> extends ParseObject<T> { | |||
* <code>current</code> will return <code>null</code>. | |||
* | |||
* @param {object} options | |||
* @param {boolean} [options.clearSession] If true, the session token will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a better explanation. It's now a rather technical description but not so clear what the purpose of the option is and why / when one should use it.
Pull Request
Issue
Currently, if trying to logout with an invalid session token, you will need to catch the error, and call logout again. It can be a bit tedious.
Closes: #307
Approach
Improves clearing session by allowing
Parse.User.logOut({ clearSession: true })
, which resolves even if invalid session token is returned.Tasks