-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add vite #2425
base: alpha
Are you sure you want to change the base?
feat: Add vite #2425
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Nice! Need some help? I'm interested in seeing how this would work with tree shaking. |
@dplewis I think the challenge here is that Vite might/webpack not be compatible with CJS. Any thoughts? |
I’m not familiar with vite but I see you have a umd bundle in your output, you should be able to output cjs. By compatibility are you referring to the input as cjs? We can change that |
Just having some issues getting some of the browser apis (crypto etc) to polyfill to node. seems to be coming along well though |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6256 6232 -24
Branches 1476 1477 +1
=========================================
- Hits 6256 6232 -24 ☔ View full report in Codecov by Sentry. |
@dplewis everything seems to be working fine except for react native crypto. Any tips would be appreciated 😊 |
@dblythy I think we should replace If we use just |
@dblythy Do you mind if I work on your branch? I see you have a few ES Module issues too. |
|
See #2501 (comment). I would like to break this chain here, as we cannot merge a breaking change into the Parse JS SDK. This PR is already holding back #2402. So if there's an easy workaround to get this PR merged without depending on #2501, then please let's do that. |
@dplewis you are welcome to work off this branch if you would like 😊 Also had a small problem with 2 of the localstorage tests |
Why vite instead of just use rollup directly? I think we could just replace browserify first then the other builds. We could just copy https://github.com/firebase/firebase-js-sdk setup |
Pull Request
Issue
Closes: #2410
Approach
Vite is more modern than webpack, so approaching building files with vite. Testing will still be needed
Tasks