-
-
Notifications
You must be signed in to change notification settings - Fork 595
ci: Add type definition check #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2462 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6256 6256
Branches 1447 1476 +29
=========================================
Hits 6256 6256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Which CI job would fail? Or should the CI build the types, compare and fail is there's a diff? I think that's how the Definitions check works in the CI. |
That’s even better, it will also catch if contributors manually change the files |
@mtrezza I took your suggestion and added a type diff checker. |
This reverts commit ef892e0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🎉 This change has been released in version 6.1.0-alpha.1 |
🎉 This change has been released in version 6.1.0 |
Pull Request
Issue
Building types in the CI doesn't mean those built types are added to the code base.
Closes: #2460
Approach
Add a type check to ensure files are properly generated
Tasks