-
-
Notifications
You must be signed in to change notification settings - Fork 69
WIP: Strip out unchanged keys on object update #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// | ||
// JSONStorage.swift | ||
// ParseSwift | ||
// | ||
// Created by Daniel Blyth on 21/10/21. | ||
// Copyright © 2021 Parse Community. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
struct JSONStorage { | ||
public static var store: [String: [String: AnyObject]] = [:] | ||
static func put<T>(object: T) where T: ParseObject { | ||
do { | ||
let encoded = try ParseCoding.jsonEncoder().encode(object) | ||
if let objectId = object.objectId, | ||
let json = try JSONSerialization.jsonObject(with: encoded, options: []) as? [String: AnyObject] { | ||
store[objectId] = json | ||
} | ||
} catch { | ||
print("Could not store object") | ||
} | ||
} | ||
static func put<T>(objects: [T]) where T: ParseObject { | ||
for parseObject in objects { | ||
put(object: parseObject) | ||
} | ||
} | ||
static func getEncodedKeys(object: ParseType) -> Set<String> { | ||
var keysToSkip: Set<String>! | ||
if !ParseSwift.configuration.allowCustomObjectId { | ||
keysToSkip = ParseEncoder.SkipKeys.object.keys() | ||
} else { | ||
keysToSkip = ParseEncoder.SkipKeys.customObjectId.keys() | ||
} | ||
guard let objectable = object as? Objectable else { | ||
return keysToSkip | ||
} | ||
do { | ||
let encoded = try ParseCoding.parseEncoder().encode(object) | ||
if let id = objectable.objectId, | ||
let previousStore = store[id], | ||
let json = try JSONSerialization.jsonObject(with: encoded, options: []) as? [String: AnyObject] { | ||
for keyName in json.keys where | ||
(json[keyName] as? NSObject) == (previousStore[keyName] as? NSObject) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
&& !keysToSkip.contains(keyName) { | ||
keysToSkip.insert(keyName) | ||
} | ||
} | ||
} | ||
} catch { | ||
|
||
} | ||
return keysToSkip | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should conform to
ParseKeyValueStorage
so it can be accessed like the other storage mediums when necessary:Parse-Swift/Sources/ParseSwift/Storage/ParseKeyValueStore.swift
Line 14 in d6be35b