fix: Incorrectly attempting to send body in GET, DELETE requests
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 93.53% 95.79% +2.25%
==========================================
Files 23 23
Lines 588 832 +244
==========================================
+ Hits 550 797 +247
+ Misses 38 35 -3 ☔ View full report in Codecov by Sentry. |
cbaker6
commented
Feb 8, 2025
|
@mtrezza this is ready for review |
mtrezza
approved these changes
Feb 8, 2025
mtrezza
changed the title
GET, DELETE requests
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 8, 2025
## [6.4.1](6.4.0...6.4.1) (2025-02-08) ### Bug Fixes * Incorrectly attempting to send body in `GET`, `DELETE` requests ([#169](#169)) ([7ca2681](7ca2681))
|
🎉 This change has been released in version 6.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #164 introduced the ability to
GETandDELETEto add functionality for channel management. Previously, the API could onlyPOST, which always required abodyto be sent. In cases ofGETandDELETE, a body shouldn't be sent. #164 attempts to only send a body when necessary but incorrectly assumes the body is anObjectwhen it is always a JSON string.This checks against an empty JSON string and adds a test to verify the body is a JSON string and not an
Object.Closes: #168