-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ci: fix lint and add husky hook #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
I would also like to add prettier but wanted to keep this PR minimal |
Also related to #1789 |
Should we merge this now or wait until we have a few more PRs merged; this may need that authors refactor their PRs. |
Your call! It's all auto-fixed anyway so it can wait |
Then I'd say let's merge a few more larger PRs first |
@dblythy I think after merging #1657 this PR should be good to go, we have merged all other larger PRs since Sept 10. The other larger PRs (#1677, #1761) have become stale and it doesn't seem as if they'd be picked up anytime soon unfortunately. I would still want us to consider whether we need enforcing pre-commit hooks, I personally am not in favor of these for reasons I have mentioned before. |
New Pull Request Checklist
Issue Description
Makes a number of improvements to Lint.
Adds indentation rules, no code changes.
Related issue: #1783
Approach
Add pre-commit hook, fixes existing lint rules.
TODOs before merging