Skip to content

ci: fix lint and add husky hook #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 8, 2021

New Pull Request Checklist

Issue Description

Makes a number of improvements to Lint.

Adds indentation rules, no code changes.

Related issue: #1783

Approach

Add pre-commit hook, fixes existing lint rules.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 8, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy
Copy link
Member Author

dblythy commented Sep 9, 2021

I would also like to add prettier but wanted to keep this PR minimal

@dblythy
Copy link
Member Author

dblythy commented Sep 9, 2021

Also related to #1789

@mtrezza
Copy link
Member

mtrezza commented Sep 10, 2021

Should we merge this now or wait until we have a few more PRs merged; this may need that authors refactor their PRs.

@dblythy
Copy link
Member Author

dblythy commented Sep 10, 2021

Your call! It's all auto-fixed anyway so it can wait

@mtrezza
Copy link
Member

mtrezza commented Sep 10, 2021

Then I'd say let's merge a few more larger PRs first

@dblythy dblythy marked this pull request as draft September 10, 2021 01:05
@mtrezza mtrezza changed the title Fix Lint and Add Husky Hook ci: fix lint and add husky hook Sep 19, 2021
@dblythy dblythy changed the base branch from alpha to beta October 6, 2021 08:44
@parse-github-assistant parse-github-assistant bot changed the base branch from beta to alpha October 6, 2021 08:44
@dblythy dblythy changed the base branch from alpha to release October 6, 2021 08:45
@parse-github-assistant parse-github-assistant bot changed the base branch from release to alpha October 6, 2021 08:45
@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2021

@dblythy I think after merging #1657 this PR should be good to go, we have merged all other larger PRs since Sept 10. The other larger PRs (#1677, #1761) have become stale and it doesn't seem as if they'd be picked up anytime soon unfortunately.

I would still want us to consider whether we need enforcing pre-commit hooks, I personally am not in favor of these for reasons I have mentioned before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants