Skip to content

fix: Improperly aligned unfolding sub-items in context menu in data browser #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Apr 7, 2025

New Pull Request Checklist

Issue Description

Closes: #2635

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Apr 7, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@dblythy dblythy changed the title Update ContextMenu.react.js fix: context menu position Apr 7, 2025
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: context menu position fix: Context menu position Apr 7, 2025
Copy link

uffizzi-cloud bot commented Apr 7, 2025

Uffizzi Ephemeral Environment deployment-62506

⌚ Updated Apr 07, 2025, 12:11 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2726

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member

mtrezza commented Apr 7, 2025

I tried out all the positions to see which ones work. It's painful that we have to spend time on fixing something that should work OOTB. I hope we get to #2460 soon.

OK

top-right short: OK

image

top-right long: OK

image

bottom-right long: OK

image

bottom-left long: OK

image

top-left short: OK

image

top-left long: OK

image

NOK

bottom-right short: NOK - subitem should align with top border; I guess the logic could be, if the count of sub-items <= count of main items, then align with the top border, as we know there is enough space towards the bottom.

image

bottom-left short: NOK

image

@mtrezza mtrezza changed the title fix: Context menu position fix: Improperly aligned unfolding sub-items in context menu in data browser Apr 7, 2025
@dblythy dblythy requested a review from a team April 9, 2025 10:51
@mtrezza mtrezza closed this Apr 10, 2025
@mtrezza mtrezza reopened this Apr 10, 2025
@mtrezza mtrezza closed this Apr 10, 2025
@mtrezza mtrezza reopened this Apr 10, 2025
Copy link

uffizzi-cloud bot commented Apr 10, 2025

Uffizzi Ephemeral Environment deployment-62642

⌚ Updated Apr 10, 2025, 01:15 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2726

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard crashes when opening session with uffizzi link

@mtrezza
Copy link
Member

mtrezza commented Apr 10, 2025

The issue seems to be a different one; I've opened #2743 with high priority, as it's currently blocking the other PRs.

@mtrezza mtrezza closed this Apr 13, 2025
@mtrezza mtrezza reopened this Apr 13, 2025
Copy link

uffizzi-cloud bot commented Apr 13, 2025

Uffizzi Ephemeral Environment deployment-62729

⌚ Updated Apr 13, 2025, 14:24 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2726

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sub-menu is always shown, even if the mouse is not over its parent item. In the screenshot below the mouse was hovering over "Edit row":

image

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Apr 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu offset incorrect
3 participants