-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: Improperly aligned unfolding sub-items in context menu in data browser #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. |
I will reformat the title to use the proper commit message syntax. |
Uffizzi Ephemeral Environment
|
I tried out all the positions to see which ones work. It's painful that we have to spend time on fixing something that should work OOTB. I hope we get to #2460 soon. OKtop-right short: OK ![]() top-right long: OK ![]() bottom-right long: OK ![]() bottom-left long: OK ![]() top-left short: OK ![]() top-left long: OK ![]() NOKbottom-right short: NOK - subitem should align with top border; I guess the logic could be, if the count of sub-items <= count of main items, then align with the top border, as we know there is enough space towards the bottom. ![]() bottom-left short: NOK ![]() |
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dashboard crashes when opening session with uffizzi link
The issue seems to be a different one; I've opened #2743 with high priority, as it's currently blocking the other PRs. |
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
New Pull Request Checklist
Issue Description
Closes: #2635
Approach
TODOs before merging