-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add row number #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
feat: Add row number #2737
Conversation
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. |
Uffizzi Ephemeral Environment
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you please:
- consider pagination when calculating the row number, e.g. the first row number should the skip value + 1
- dynamically adapt the width of the number column to the number text width
New Pull Request Checklist
Issue Description
Closes: #2484
Approach
TODOs before merging