Skip to content

feat: Add row number #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Apr 9, 2025

New Pull Request Checklist

Issue Description

Closes: #2484

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add row number feat: Add row number Apr 9, 2025
Copy link

parse-github-assistant bot commented Apr 9, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Copy link

uffizzi-cloud bot commented Apr 9, 2025

Uffizzi Ephemeral Environment deployment-62613

⌚ Updated Apr 09, 2025, 11:41 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2737

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza closed this Apr 13, 2025
@mtrezza mtrezza reopened this Apr 13, 2025
Copy link

uffizzi-cloud bot commented Apr 13, 2025

Uffizzi Ephemeral Environment deployment-62726

⌚ Updated Apr 13, 2025, 14:29 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2737

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you please:

  • consider pagination when calculating the row number, e.g. the first row number should the skip value + 1
  • dynamically adapt the width of the number column to the number text width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add row number to data browser
2 participants