Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to mongo allowDiskUse #8337

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

stewones
Copy link
Contributor

@stewones stewones commented Nov 27, 2022

New Pull Request Checklist

Issue Description

Dependent: parse-community/Parse-SDK-JS#1623
Closes: #7765

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add support to mongo allowDiskUse feat: Add support to mongo allowDiskUse Nov 27, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 27, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 94.25% // Head: 93.93% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (96427c0) compared to base (6f52744).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8337      +/-   ##
==========================================
- Coverage   94.25%   93.93%   -0.33%     
==========================================
  Files         180      180              
  Lines       13960    13981      +21     
==========================================
- Hits        13158    13133      -25     
- Misses        802      848      +46     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.97% <ø> (ø)
src/Controllers/DatabaseController.js 93.91% <ø> (ø)
src/RestQuery.js 95.78% <ø> (ø)
src/Adapters/Storage/Mongo/MongoCollection.js 95.45% <50.00%> (-2.17%) ⬇️
src/Routers/ClassesRouter.js 96.00% <50.00%> (-0.94%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 15.55% <0.00%> (-75.56%) ⬇️
src/LiveQuery/ParseCloudCodePublisher.js 83.33% <0.00%> (-16.67%) ⬇️
src/ParseServerRESTController.js 96.96% <0.00%> (-1.52%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <0.00%> (-0.73%) ⬇️
src/RestWrite.js 94.46% <0.00%> (-0.45%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza mentioned this pull request Dec 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to use allowDiskUse on mongo
1 participant