-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Allow File adapter to create file with specific locations or dynamic filenames #9557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdrianCurtin
wants to merge
19
commits into
parse-community:alpha
Choose a base branch
from
AdrianCurtin:alpha
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d46f1ce
Allow file adapter to override file name and location + give createFi…
AdrianCurtin cc7027e
Only call getFileLocation if no url is provided
AdrianCurtin ff9441f
Modify description and typescript
AdrianCurtin 1578b7b
Add optional location element too
AdrianCurtin e0015c1
Update FilesAdapter.js
AdrianCurtin a1ccce1
Remove trialing space
AdrianCurtin 433423c
change to undefined as a fallback
AdrianCurtin 2c76b13
Add tests for different return conditions
AdrianCurtin a6c2609
Update description of config slightly
AdrianCurtin 3d14641
Merge branch 'alpha' into alpha
AdrianCurtin f87169b
Merge branch 'alpha' into alpha
mtrezza 05b6ac6
Merge branch 'alpha' into alpha
AdrianCurtin 21cb8e4
Merge branch 'alpha' into alpha
AdrianCurtin 441c291
Modify mock adapter initialization to use struct in beginning
AdrianCurtin 10eb23e
Update to include config in arguments for createFileSpy
AdrianCurtin 79eeda4
Merge branch 'alpha' into alpha
AdrianCurtin 583699e
Merge branch 'alpha' into alpha
AdrianCurtin 0581094
Remove space + move preserve filename args to files controller initia…
AdrianCurtin 0f21073
Merge branch 'alpha' into alpha
AdrianCurtin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.