-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: Fixed issue where deeply nested keys were having incorrect values #9720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
fix: Fixed issue where deeply nested keys were having incorrect values #9720
Conversation
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9720 +/- ##
==========================================
- Coverage 93.01% 84.38% -8.63%
==========================================
Files 187 187
Lines 15081 15072 -9
Branches 174 174
==========================================
- Hits 14028 12719 -1309
- Misses 1041 2341 +1300
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks like it’s failing in Postgres, getting recursive coalesces (dot notation) working would be a challenge |
I'll try to work on this part, do you have any insights on where to look into? I'm not a Postgres expert |
Here you go, it might work I'll try as well, might be a week parse-server/src/Adapters/Storage/Postgres/PostgresStorageAdapter.js Lines 185 to 187 in ed69e03
|
@RahulLanjewar93 We can make this test Mongo only as PG Dot notation support is limited already. |
Ok I'll make changes accordingly then |
I will reformat the title to use the proper commit message syntax. |
refer #7385 (comment)