Skip to content

fix: Fixed issue where deeply nested keys were having incorrect values #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

RahulLanjewar93
Copy link
Contributor

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: fixed issue where deeply nested keys were having incorrect values fix: Fixed issue where deeply nested keys were having incorrect values Apr 16, 2025
Copy link

parse-github-assistant bot commented Apr 16, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (ed69e03) to head (e8ae442).

❗ There is a different number of reports uploaded between BASE (ed69e03) and HEAD (e8ae442). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (ed69e03) HEAD (e8ae442)
10 6
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9720      +/-   ##
==========================================
- Coverage   93.01%   84.38%   -8.63%     
==========================================
  Files         187      187              
  Lines       15081    15072       -9     
  Branches      174      174              
==========================================
- Hits        14028    12719    -1309     
- Misses       1041     2341    +1300     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis
Copy link
Member

dplewis commented Apr 16, 2025

Looks like it’s failing in Postgres, getting recursive coalesces (dot notation) working would be a challenge

@RahulLanjewar93
Copy link
Contributor Author

Looks like it’s failing in Postgres, getting recursive coalesces (dot notation) working would be a challenge

I'll try to work on this part, do you have any insights on where to look into? I'm not a Postgres expert

@dplewis
Copy link
Member

dplewis commented Apr 16, 2025

Here you go, it might work I'll try as well, might be a week

const handleDotFields = object => {
Object.keys(object).forEach(fieldName => {

@dplewis
Copy link
Member

dplewis commented Apr 16, 2025

@RahulLanjewar93 We can make this test Mongo only as PG Dot notation support is limited already.

@RahulLanjewar93
Copy link
Contributor Author

@RahulLanjewar93 We can make this test Mongo only as PG Dot notation support is limited already.

Ok I'll make changes accordingly then

@RahulLanjewar93 RahulLanjewar93 changed the title fix: Fixed issue where deeply nested keys were having incorrect values fix: fixed issue where deeply nested keys were having incorrect values Apr 16, 2025
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: fixed issue where deeply nested keys were having incorrect values fix: Fixed issue where deeply nested keys were having incorrect values Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants