ci: Fix eslint config #9723
ci: Fix eslint config #9723
Conversation
|
🚀 Thanks for opening this pull request! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #9723 +/- ##
==========================================
- Coverage 93.01% 92.98% -0.04%
==========================================
Files 187 187
Lines 15081 15112 +31
Branches 174 174
==========================================
+ Hits 14028 14052 +24
- Misses 1041 1048 +7
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| it_id('23caddd7-bfea-4869-8bd4-0f2cd283c8bd')(it)( | ||
| 'can start Parse Server with auth via CLI', | ||
| done => { |
There was a problem hiding this comment.
What line length is this enforcing? Looks less readable to me this way.
There was a problem hiding this comment.
Looks like prettier has a 100 line length
There was a problem hiding this comment.
Should we set this to longer lines, like 170?
There was a problem hiding this comment.
We could but it’s up to you to review 170+ files being changed. My plan was to remove prettier and husky anyway like the JS SDK. Should I just redo this PR without running prettier?
There was a problem hiding this comment.
Should I just redo this PR without running prettier?
I think that would be good; we may consider running a reformat across all files in a dedicated PR, if it's worth it. It's just such a large change that I'm afraid it would create merge conflicts or complicated rebases across pending PRs. Maybe we can do this if we get to a point where we clean up the PR list.
Pull Request
Issue
Eslint is broken, runs prettier