Updated SES library dependency to one that supports SES Signature v4 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acinader @nlutsenko This module is currently 100% broken because AWS no longer accepts V3 requests. this PR is meant to fix that, can we prioritize its review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SES adapter was depending on the outdated
amazon-ses-mailerpackage. The old package was using the SES v3 signing and Amazon started blocking those requests in March 2021.This PR updates the dependency to a new package
node-seswhich uses v4 signing. It was a pretty straightforward rewrite to use the new package.Tested on my v3.10 Parse server instance. The API is pretty straightforward so I imagine it should work without problem on newer Parse Server versions.