Code

Current iteration#242

Code

Merged

jvdb merged 26 commits intomasterparsingdata/metal:masterfrom current-indexparsingdata/metal:current-indexCopy head branch name to clipboardSep 17, 2018

+389-103

Commits

Commits on Jul 2, 2018

• #236: Basic, compiling and failing tests for the CurrentIndex ValueExpression.

  jvdb

  committed
  e725c68

  Copy full SHA for e725c68

Commits on Jul 3, 2018

• #236: Added test for another Token that needs to be included: While.

  jvdb

  committed
  e6b2f37

  Copy full SHA for e6b2f37

Commits on Jul 4, 2018

• #236: Basic implementation and tests.

  jvdb

  committed
  0e12551

  Copy full SHA for 0e12551

• #236: Added (failing) test for using CurrentIndex in a nested iterable.

  jvdb

  committed
  dac4afb

  Copy full SHA for dac4afb

Commits on Jul 17, 2018

• #236: Improved currentIndex implementation by looking for the deepest iterable and counting siblings a long the way.

  mvanaken

  committed
  b449cff

  Copy full SHA for b449cff

Commits on Jul 18, 2018

• #236: Renamed CurrentIndex to CurrentIteration to better reflect what it represents. Cleaned up test a bit.

  jvdb

  committed
  a294916

  Copy full SHA for a294916

• #236: Fixed one of the CurrentIteration tests.

  jvdb

  committed
  ec291c2

  Copy full SHA for ec291c2

• #236: Simplified implementation of CurrentIteration, which also improves coverage.

  jvdb

  committed
  c3c961e

  Copy full SHA for c3c961e

• #236: Improved test coverage for CurrentIteration.

  jvdb

  committed
  cab9c3e

  Copy full SHA for cab9c3e

• #236: Converted CurrentIteration to use trampolines for recursion.

  jvdb

  committed
  3450821

  Copy full SHA for 3450821

• #236: Added unit test for CurrentIteration.

  jvdb

  committed
  0d2401b

  Copy full SHA for 0d2401b

Commits on Jul 20, 2018

• #236: Keep track of the last iterable instead of the last iteration and count the iterations of the iterable afterwards.

  mvanaken

  committed
  ad98634

  Copy full SHA for ad98634

Commits on Jul 21, 2018

• #236: Small refactorings.

  jvdb

  committed
  f8f5034

  Copy full SHA for f8f5034

Commits on Jul 24, 2018

• #236: Make CurrentIteration return empty value when referencing outside an iterable scope.

  mvanaken

  committed
  a17967c

  Copy full SHA for a17967c

Commits on Jul 31, 2018

• #236: More tests. Unfortunately, no way to more precisely check for empty.

  jvdb

  committed
  b2961aa

  Copy full SHA for b2961aa

Commits on Aug 20, 2018

• #236: New implementation for current iteration, which is now tracked within ParseState, instead of extracting it out of the ParseGraph. The iteration is now independent on the parse result.

  mvanaken

  committed
  6fa43c5

  Copy full SHA for 6fa43c5

• #236: Removed redundant import.

  mvanaken

  committed
  ebfcf71

  Copy full SHA for ebfcf71

Commits on Aug 24, 2018

• #236: Processed review comments of @rdvdijk.

  mvanaken

  committed
  6b72849

  Copy full SHA for 6b72849

• #236: Included ToString test for ParseState with iterations.

  mvanaken

  committed
  fe71ac2

  Copy full SHA for fe71ac2

Commits on Sep 3, 2018

• #236: Processed review comments from @rdvdijk @ccreeten.

  mvanaken

  committed
  8f9d2c3

  Copy full SHA for 8f9d2c3

• #236: Fixed a failing test.

  jvdb

  committed
  97a66c5

  Copy full SHA for 97a66c5

Commits on Sep 10, 2018

• #236: Added test to repair test coverage.

  jvdb

  committed
  5442e7a

  Copy full SHA for 5442e7a

Commits on Sep 15, 2018

• 236: Improved CurrentIterationTest.

  jvdb

  committed
  93716c3

  Copy full SHA for 93716c3

• 236: Improved CurrentIterationTest to actually verify zero-sized Def and CURRENT_ITERATION behaviour inside an IterableToken.

  jvdb

  committed
  fd803d8

  Copy full SHA for fd803d8

Commits on Sep 16, 2018

• #236: Replaced null-check with isEmpty()-call, added newline, improved javadoc. Based on review comments from @rdvdijk and @ccreeten.

  jvdb

  committed
  c63f84c

  Copy full SHA for c63f84c

• #236: Removed dependency on the javafx Pair class by adding trivial ImmutablePair class.

  jvdb

  committed
  840c354

  Copy full SHA for 840c354