-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cesar/upgrading okhttp #13
Open
CesarValiente
wants to merge
20
commits into
particle-iot:master
Choose a base branch
from
CesarValiente:cesar/upgrading_okhttp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cesar/upgrading okhttp #13
CesarValiente
wants to merge
20
commits into
particle-iot:master
from
CesarValiente:cesar/upgrading_okhttp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and intellij files
…which builds Fontify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
----------- Note -----------
This branch (pull request) is a continuation and was started from the still active pull request: #12
I did that because I'm developing using AndroidStudio and gradle and actually is the "standard" way now, so these two pull requests should be reviewed asap (and merged) so other developers (mainly all) can help to improve the app using the "usual" Android development way.
------ Stuff done in this pull request (starting commit id: 31fdc50 ) ---------
Okhttp has been updated and with it the rest of the libraries Spark android-app is using.
The libraries are retrieved from Mavencentral.
The way the app was using urlconnection instances now has been updated, since they are created using a factory now.