Delete task outside of critical section to avoid malloc mutex deadlock#4
Open
scott-brust wants to merge 1 commit into
Open
Delete task outside of critical section to avoid malloc mutex deadlock#4scott-brust wants to merge 1 commit into
scott-brust wants to merge 1 commit into
Conversation
avtolstoy
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During USB de-initialization, the realtek SDK will delete its internal USB Freertos task. This process involves freeing malloc'd memory. Our heap implementation is protected by a mutex, which can be unavailable if another task holds the mutex.
The default implementation of
vTaskDelete()in freertos deletes all tasks under a critical section, ie with interrupts disabled.If we call
vTaskDelete()while another task holds the malloc mutex, we will deadlock as interrupts are disabled.This PR moves the actual tcb deletion / freeing outside of the critical section in order to avoid deadlocks on this mutex.
See original discussion here
Credit to @avtolstoy for the fix.