-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest partiql-tests #512
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 80.85% 80.69% -0.17%
==========================================
Files 80 80
Lines 19405 19405
Branches 19405 19405
==========================================
- Hits 15690 15658 -32
- Misses 3291 3322 +31
- Partials 424 425 +1 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5520 Number failing in both: 604 Number passing in Base (3f3a948) but now fail: 190 Number failing in Base (3f3a948) but now pass: 3 Click here to see
Click here to see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should update partiql-tests
again after partiql/partiql-tests#128 is merged in.
That's the plan. I wanted to do this update first. Then pull that in to show only changes from partiql/partiql-tests#128 See #513 |
Some test have changed and more have been added.
It is expected that there might appear to be some test regressions due to the changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.