Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes formatting of data, causing issues in experimental evaluator #111

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fixes formatting of data, causing issues in experimental evaluator #111

merged 1 commit into from
Apr 16, 2024

Conversation

johnedquinn
Copy link
Member

Relevant Issue

  • None

Description

  • Fixes formatting of data, causing issues in experimental evaluator
  • Quantitative impact:
    • For new evaluator, "Number passing in legacy engine but fail in eval engine: " 760 --> 692
    • This translates to a conformance increase: 82.40% --> 83.57%
    • Old evaluator stays the same in conformance. Passing 5382 tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnedquinn johnedquinn merged commit 8ffba8a into main Apr 16, 2024
4 checks passed
@johnedquinn johnedquinn deleted the v1-conformance-formatting-error branch April 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchowell rchowell rchowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnedquinn @rchowell