Skip to content

Update .nvmrc#11

Open
pasha-codefresh wants to merge 1 commit into
masterfrom
some-test-pr
Open

Update .nvmrc#11
pasha-codefresh wants to merge 1 commit into
masterfrom
some-test-pr

Conversation

@pasha-codefresh
Copy link
Copy Markdown
Owner

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Update Node.js version to 24.14.4 in ui/.nvmrc

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update Node.js version from 24.14.1 to 24.14.4
• Bumps nvmrc configuration in ui directory
Diagram
flowchart LR
  A["ui/.nvmrc<br/>24.14.1"] -- "version bump" --> B["ui/.nvmrc<br/>24.14.4"]
Loading

Grey Divider

File Changes

1. ui/.nvmrc ⚙️ Configuration changes +1/-1

Bump Node.js version to 24.14.4

• Updates Node.js version specification from 24.14.1 to 24.14.4
• Applies patch-level version bump for UI development environment

ui/.nvmrc


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Apr 26, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Node version drift 🐞 Bug ⚙ Maintainability
Description
ui/.nvmrc is updated to Node 24.14.4, but Docker-based UI build and dev images are still pinned to
node:24.14.1, creating a local-vs-container runtime mismatch. This can lead to non-reproducible UI
builds/tests and “works locally but fails in container/CI” issues when Node patch behavior differs.
Code

ui/.nvmrc[1]

+24.14.4
Evidence
The PR changes the nvm-selected Node version for UI dev to 24.14.4, while the UI build stage in the
main Dockerfile (and the Tilt/UI-test Dockerfiles) still explicitly pull Node 24.14.1 by tag+digest,
so the repository now specifies two different Node patch versions for UI-related workflows.

ui/.nvmrc[1-1]
Dockerfile[92-108]
Dockerfile.ui.tilt[1-9]
ui-test/Dockerfile[1-5]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`ui/.nvmrc` was bumped to Node `24.14.4`, but Docker-based UI build/dev/test images still pin Node `24.14.1`. This creates an environment drift between local development (nvm) and containerized builds.

### Issue Context
The UI is built in Docker (`argocd-ui` stage) and also has a Tilt Dockerfile and a UI-test Dockerfile pinned to a specific Node tag+digest.

### Fix Focus Areas
- ui/.nvmrc[1-1]
- Dockerfile[92-108]
- Dockerfile.ui.tilt[1-9]
- ui-test/Dockerfile[1-5]

### What to change
- Either:
 1) Update the pinned Node image tags/digests in the Dockerfiles from `24.14.1` to `24.14.4` (including updating the sha256 digest accordingly), so local and container builds use the same Node patch; **or**
 2) Revert `ui/.nvmrc` back to `24.14.1` if the container pin is the intended source of truth.

After updating, ensure the UI build steps (`pnpm install --frozen-lockfile` and `pnpm build`) still succeed under the chosen Node version.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant