Skip to content

Commit a586397

Browse files
authored
chore: Fix go version during ci lint (argoproj#401)
* chore: Fix go version during ci lint Signed-off-by: Leonardo Luz Almeida <[email protected]> * Fix go version minor version only Signed-off-by: Leonardo Luz Almeida <[email protected]>
1 parent 73bcea9 commit a586397

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
pull_request:
99
branches:
1010
- 'master'
11+
env:
12+
# Golang version to use across CI steps
13+
GOLANG_VERSION: '1.17'
1114
jobs:
1215
test:
1316
runs-on: ubuntu-latest
@@ -21,13 +24,14 @@ jobs:
2124
${{ runner.os }}-go-
2225
- uses: actions/[email protected]
2326
with:
24-
go-version: '1.17.6'
27+
go-version: ${{ env.GOLANG_VERSION }}
2528
- run: make test
2629
- name: Run golangci-lint
2730
uses: golangci/golangci-lint-action@v2
2831
with:
2932
version: v1.38.0
3033
args: --timeout 5m
34+
skip-go-installation: true
3135
- uses: codecov/[email protected]
3236
with:
3337
token: ${{ secrets.CODECOV_TOKEN }} #required

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.14.3 as builder
1+
FROM golang:1.17 as builder
22

33
WORKDIR /src
44

@@ -13,4 +13,4 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="-w -s" -o /dist/git
1313

1414

1515
FROM alpine/git:v2.24.3
16-
COPY --from=builder /dist/gitops /usr/local/bin/gitops
16+
COPY --from=builder /dist/gitops /usr/local/bin/gitops

0 commit comments

Comments
 (0)