Skip to content

[1.3.0] Add support for Flight/Vehicle/Shipping estimates #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • Adding support for Flight/Vehicle/Shipping estimates
  • Increasing version to 1.3.5 to track the Patch Ruby SDK and Patch Node SDK

Why

  • To extend the Python library to also handle Flight/Shipping/Vehicle estimates.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production? N/A

@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 8, 2021
@biglovisa biglovisa self-assigned this Feb 8, 2021
@biglovisa biglovisa requested a review from thdaraujo February 8, 2021 22:22
@biglovisa biglovisa changed the title [1.3.5] Add support for Flight/Vehicle/Shipping estimates [1.3.0] Add support for Flight/Vehicle/Shipping estimates Feb 8, 2021
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, left a few nitpicks.

@@ -43,6 +43,61 @@ def test_create_and_retrieve_mass_estimate(self):
retrieved_estimate = self.api.retrieve_estimate(id=estimate.data.id)
self.assertTrue(retrieved_estimate)

def test_create_and_retrieve_flight_estimate(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 9, 2021
Co-authored-by: Thiago Araujo <[email protected]>
@biglovisa biglovisa merged commit 4b06c67 into main Feb 9, 2021
@biglovisa biglovisa deleted the lovisa/version-1.3.5 branch February 9, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready This PR is ready to ship!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants