Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused estimates endpoint #77

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Remove unused estimates endpoint #77

merged 1 commit into from
Jan 11, 2025

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Jan 10, 2025 •
edited
Loading

What

Remove retired estimates API endpoints:

  • create_ethereum_estimate
  • create_shipping_estimate
  • create_vehicle_estimate

Why

  • The endpoints have been retired

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version in the code generator?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

pcothenet
pcothenet commented Jan 10, 2025
View reviewed changes
.rubocop.yml
EnforcedStyle: indented_internal_methods
EnforcedStyle: normal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change this because it wasn't supported anymore

@pcothenet pcothenet requested a review from holtbp January 10, 2025 23:56
@pcothenet pcothenet merged commit f8dccdf into main Jan 11, 2025
3 checks passed
@pcothenet pcothenet deleted the pc/2_3 branch January 11, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtbp holtbp holtbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @holtbp