Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tower-sessions (0.14.0) and axum (0.8) dependencies #23

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

arthmis
Copy link
Contributor

@arthmis arthmis commented Jan 21, 2025

Hi I tried using this session store while developing a project and ran into some compatibility issues since I was on axum 0.8. This updates the axum and tower-sessions dependencies

@arthmis
Copy link
Contributor Author

arthmis commented Jan 21, 2025

seems the CI is running into the same issue I was getting, not finding a sqlite library to link to.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.49%. Comparing base (730fdc0) to head (9068eae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files           1        1           
  Lines         118      118           
=======================================
  Hits           82       82           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patte
Copy link
Owner

patte commented Jan 22, 2025

Hi @arthmis! Thank you very much for the PR! 🙏
The tests were running before on github, something must have changed, thanks for suggesting the bundeled version. After merging the 2 PRs from you, I will bump some other dependencies (matchit, thiserror, tower-cookies) and then release a new version.

P.S. I was under the impression that dependabot will notify me about such important updates, but because I ignored some unimportant PRs from it (eg. thiserror) it paused sending further PRs, TIL.

@patte patte changed the title update tower session and axum dependencies update tower-session (0.14.0) and axum (0.8) dependencies Jan 22, 2025
@patte patte changed the title update tower-session (0.14.0) and axum (0.8) dependencies update tower-sessions (0.14.0) and axum (0.8) dependencies Jan 22, 2025
@patte patte merged commit a1115f8 into patte:main Jan 22, 2025
3 checks passed
@patte
Copy link
Owner

patte commented Jan 22, 2025

@arthmis v0.14.0 has been released on crates.io.
As soon as tokio-rusqlite has updated to rusqlite v0.33 (programatik29/tokio-rusqlite#42) I'll release v0.14.1.

@arthmis
Copy link
Contributor Author

arthmis commented Jan 22, 2025

Thanks for the quick merge, makes my life easier 😄 Now I don't have to link to a local copy in my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants