Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Expand exception preservation to more scenarios #162

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

pauldmccarthy
Copy link
Owner

@pauldmccarthy pauldmccarthy commented Nov 26, 2024

Use the mechanism from #152 in more scenarios, including:

  • at creation
  • seek
  • build_full_index
  • export_index
  • import_index

Also:

  • fixes a subtle bug in zran_file_util.c:_fwrite_python, where an exception raised by the file-like write method could be absorbed.
  • Attempt to work around unexplainable test failures on Windows+free-threaded Python
  • Remove a workaround for cython<=0.26, where a cdef method could not be decorated with contextlib.contextmanager

@pauldmccarthy pauldmccarthy merged commit 71a3a79 into main Nov 26, 2024
30 checks passed
@pauldmccarthy pauldmccarthy deleted the mnt/propagate-exceptions-everywhere branch November 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant