Skip to content

[MERGED] Re-enable warning 239 for native functions #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[MERGED] Re-enable warning 239 for native functions #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
913eac5
Revert "disable 239 for native functions"
Daniel-Cortez Jul 26, 2019
3f87cf1
Update tests for 239
Daniel-Cortez Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/compiler/sc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2216,7 +2216,7 @@ static int nesting=0;
if (arg[argidx].numdim!=1) {
error(48); /* array dimensions must match */
} else {
if (lval.sym==NULL && (arg[argidx].usage & uCONST)==0 && (sym->usage & uNATIVE)==0)
if (lval.sym==NULL && (arg[argidx].usage & uCONST)==0)
error(239);
if (arg[argidx].dim[0]!=0) {
assert(arg[argidx].dim[0]>0);
Expand Down
1 change: 1 addition & 0 deletions source/compiler/tests/const_array_args_and_literals_gh_276.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ const_array_args_and_literals_gh_276.pwn(30) : warning 214: possibly a "const" a
const_array_args_and_literals_gh_276.pwn(39) : warning 239: literal array/string passed to a non-const parameter
const_array_args_and_literals_gh_276.pwn(40) : warning 239: literal array/string passed to a non-const parameter
const_array_args_and_literals_gh_276.pwn(41) : warning 239: literal array/string passed to a non-const parameter
const_array_args_and_literals_gh_276.pwn(60) : warning 239: literal array/string passed to a non-const parameter
"""
}