-
Notifications
You must be signed in to change notification settings - Fork 77
[MERGED] Improvements for detection of unused assignments #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've not read the code fully. Does this handle |
Not sure what you mean exactly. Can you give an example so I could check it (and see what I can do about it, if necessary)? |
Tag:operator=(Tag:a)
{
printf("hi");
return Tag:(_:a * 2);
}
main()
{
new Tag:a = 5, Tag:b;
// Unused assignment that does something.
b = a;
} |
Done, overloaded assignments are now handled without printing warning 204. |
…gnment or symbol destruction
…o value assigned at variable definition
…e end of function
… as `uASSIGNED` at the beginning of function body
c1e49a5
to
456e837
Compare
DoSomething(arg) // Now 'arg' is marked as `uASSIGNED` ("assigned a value
{ // that is not used yet") upon the beginning of function body.
arg = 1; // warning 240: previously assigned value is never used
// (previously the compiler couldn't detect this).
#pragma unused arg
} |
This allows to detect unused assignments inside "if" statements, e.g. ``` main() { new var = 1; if (var) var = 0; // the value assigned to "var" is not used upon return } ```
…previously defined label
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does the following:
previously assigned value is never used
).Which issue(s) this PR fixes:
Fixes #479
What kind of pull this is:
Additional Documentation:
Currently warning 240 doesn't work on arrays, as it would require a lot more modifications to track assignments to each array element individually.
It is also worth noting that some of the code parts in this PR were copied from the implementation of warning 210, as both of them work by the same principle.