feat: Implement validation for token max order amount against provision bucket size #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundayonah
requested review from
chibie,
5ran6 and
OnahProsperity
as code owners
chibie
requested changes
Feb 20, 2025
controllers/accounts/profile_test.go
Outdated
Comment on lines
790
to
834
| // t.Run("GetSenderProfile", func(t *testing.T) { | ||
| // testUser, err := test.CreateTestUser(map[string]interface{}{ | ||
| // "email": "[email protected]", | ||
| // "scope": "sender", | ||
| // }) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // sender, err := test.CreateTestSenderProfile(map[string]interface{}{ | ||
| // "domain_whitelist": []string{"mydomain.com"}, | ||
| // "user_id": testUser.ID, | ||
| // }) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // apiKeyService := services.NewAPIKeyService() | ||
| // _, _, err = apiKeyService.GenerateAPIKey( | ||
| // context.Background(), | ||
| // nil, | ||
| // sender, | ||
| // nil, | ||
| // ) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // accessToken, _ := token.GenerateAccessJWT(testUser.ID.String(), "sender") | ||
| // headers := map[string]string{ | ||
| // "Authorization": "Bearer " + accessToken, | ||
| // } | ||
| // res, err := test.PerformRequest(t, "GET", "/settings/sender", nil, headers, router) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // // Assert the response body | ||
| // assert.Equal(t, http.StatusOK, res.Code) | ||
| // var response struct { | ||
| // Data types.SenderProfileResponse | ||
| // Message string | ||
| // } | ||
| // err = json.Unmarshal(res.Body.Bytes(), &response) | ||
| // assert.NoError(t, err) | ||
| // assert.Equal(t, "Profile retrieved successfully", response.Message) | ||
| // assert.NotNil(t, response.Data, "response.Data is nil") | ||
| // assert.Greater(t, len(response.Data.Tokens), 0) | ||
| // assert.Contains(t, response.Data.WebhookURL, "https://example.com") | ||
|
|
||
| // }) | ||
|
|
||
| } |
There was a problem hiding this comment.
remove comment if not needed
controllers/accounts/profile_test.go
Outdated
Comment on lines
752
to
754
| Network: "bitcoin", | ||
| Address: "bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh", | ||
| }, |
There was a problem hiding this comment.
use an evm network as example
polygon and a 0x.... address
controllers/accounts/profile_test.go
Outdated
Comment on lines
713
to
715
| Network: "bitcoin", | ||
| Address: "bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh", | ||
| }, |
controllers/accounts/profile_test.go
Outdated
Comment on lines
675
to
677
| Network: "bitcoin", | ||
| Address: "bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh", | ||
| }, |
controllers/accounts/profile_test.go
Outdated
Comment on lines
637
to
639
| Network: "bitcoin", | ||
| Address: "bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh", | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces validation for the provider's token max order amount in relation to the largest provision bucket size for their local currency. When updating a token's max order amount, the system now ensures that the amount, converted to the provider's local currency, does not exceed the size of the largest provision bucket. If the amount exceeds the largest bucket, or if no provision buckets exist for the provider's currency, the request is rejected with an appropriate error message.
References
closes #399
Testing
Checklist
main