[DTPPCPSDK-2824] [DTPRP-1734] [DTPRP-1751] Limit eligible button to Paypal when new createSubscription is used #2456
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
=======================================
Coverage ? 56.54%
=======================================
Files ? 150
Lines ? 13209
Branches ? 814
=======================================
Hits ? 7469
Misses ? 5638
Partials ? 102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/zoid/buttons/component.jsx
Outdated
| @@ -613,6 +614,16 @@ export const getButtonsComponent: () => ButtonsComponent = memoize(() => { | |||
| value: getIntent, | |||
| }, | |||
|
|
|||
| isFsSubscription: { | |||
There was a problem hiding this comment.
Can we utilize the flow param to pass this value instead of introducing another param
https://github.com/paypal/paypal-checkout-components/blob/8f3c86937696fa5605c961dd02b883ab94be77a4/src/zoid/buttons/component.jsx#L473C7-L473C11
There was a problem hiding this comment.
@ravishekhar @imbrian What new flow should I name it as?
Do we want a way to distinguish the FSS and NGS here?
There was a problem hiding this comment.
We need to differentiate is from existing subscriptions. full_stack_subscription_setup?
There was a problem hiding this comment.
I can do that @imbrian
There was a problem hiding this comment.
@ravishekhar @imbrian I'm noticing that when we use flow, we have to update the config for each funding each time. I can submit this code, but wanted to check once if this is the expected behavior. Thank you.
Right now since we're only enabling the PayPal button, I'm only adding this in the PayPal config:
https://github.com/paypal/paypal-checkout-components/blob/main/src/funding/paypal/config.jsx#L21-L26
Description
This PR is for this JIRA: https://paypal.atlassian.net/browse/DTPPCPSDK-2824
FSS = Full Stack subscription
NGS = Next Gen subscription
Goal: When we have FSS, we want to limit the only to PayPal button.
When we have NGS, we need to show all the branded buttons as usual.
NGS requirements:
createSubscription() callback must be passed
onApprove() callback must be passed
intent=subscription must be passed
vault=true must be passed
sdkToken can either be passed or not
FSS requirements:
createSubscription() callback must be passed
onApprove() callback must be passed (for CardFields, unbranded)
No intent=subscription can be passed
vault=true can either be passed or not
sdkToken must be passed and truthy
Screenshots:
Case of NGS:
Case of FSS:
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
JIRA: https://paypal.atlassian.net/browse/DTPPCPSDK-2824
We are making this change to support the new Fullstack Subscription.
Reproduction Steps (if applicable)
http://localhost.paypal.com:8080/xo-integrations/paypal/subscriptions
Screenshots (if applicable)
(See above)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!