Migration/react paypal js #496
Conversation
* We add the [`prepack` script][prepack] to take care of building the distribution. This removes the extra `build` command from `./scripts/publish.js` and makes it possible to use this package as a git dependency. * We remove the `dist` folder before packing to avoid including any unnecessary artifacts. * We explicitly generate type declarations with `tsc`. The rollup plugin only generates type declarations if `output.dir` instead of `output.file` is specified. [prepack]: https://docs.npmjs.com/cli/v7/using-npm/scripts
We prevent typescript from generating declarations that reference the `@paypal/sdk-constants` package. This package does not provide types, instead we use our own type declarations in `./src/types.d.ts`. These declarations are not available to users of the library. Fixes https://github.com/paypal/react-paypal-js/issues/125
The 'data-react-paypal-script-id' attribute uses the hash value from this `hashStr(JSON.stringify(options))` function. This change fixes an issue where a large `options` object could cause a numeric overflow.
Hotfix/form type correction
Co-authored-by: elizabethmv <[email protected]>
Co-authored-by: elizabethmv <[email protected]>
…es.tsx Co-authored-by: elizabethmv <[email protected]>
….stories.tsx Co-authored-by: elizabethmv <[email protected]>
….stories.tsx Co-authored-by: elizabethmv <[email protected]>
Co-authored-by: elizabethmv <[email protected]>
…es.tsx Co-authored-by: elizabethmv <[email protected]>
Co-authored-by: elizabethmv <[email protected]>
docs: add storybook for CardField components
Co-authored-by: Andriy Kuts <[email protected]>
|
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
| test("should return object if data client token is a valid string", () => { | ||
| const state = { | ||
| options: { | ||
| dataClientToken: "JKHFGDHJ657", |
There was a problem hiding this comment.
❗Cycode: Secret of type: 'Generic Password' was found.
Severity: Medium
Description
A generic secret or password is an authentication token used to access a computer or application and is assigned to a password variable.
Would you like to exclude this secret from your status checks?
Tell us what to do with one of the following hashtags:
| Tag | Short Description |
|---|---|
| #cycode_secret_ignore_here | Applies to this request only |
|
Git issues |
Internal ticket reference:
DTPPCPSDK-2407react-paypal-jsrepo to be a package inside ofpaypal-js.react-paypal-jsin this migration so that is the reason why we are seeing all of the commits in this PR.