Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/react paypal js #498

Closed
wants to merge 432 commits into from
Closed

Migrate/react paypal js #498

wants to merge 432 commits into from

Conversation

sebastianfdz
Copy link
Contributor

wip

gregjopa and others added 30 commits July 6, 2021 13:49
* We add the [`prepack` script][prepack] to take care of building the
  distribution. This removes the extra `build` command from
  `./scripts/publish.js` and makes it possible to use this package as a
  git dependency.
* We remove the `dist` folder before packing to avoid including any
  unnecessary artifacts.
* We explicitly generate type declarations with `tsc`. The rollup plugin
  only generates type declarations if `output.dir` instead of
  `output.file` is specified.

[prepack]: https://docs.npmjs.com/cli/v7/using-npm/scripts
We prevent typescript from generating declarations that reference the
`@paypal/sdk-constants` package. This package does not provide types,
instead we use our own type declarations in `./src/types.d.ts`. These
declarations are not available to users of the library.

Fixes https://github.com/paypal/react-paypal-js/issues/125
The 'data-react-paypal-script-id' attribute uses the hash value from
this `hashStr(JSON.stringify(options))` function. This change fixes
an issue where a large `options` object could cause a numeric overflow.
mchoun and others added 25 commits April 25, 2024 17:33
docs: add storybook for CardField components
Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: 8756e16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

test("should return object if data client token is a valid string", () => {
const state = {
options: {
dataClientToken: "JKHFGDHJ657",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycode: Secret of type: 'Generic Password' was found.
Severity: Medium

Description

A generic secret or password is an authentication token used to access a computer or application and is assigned to a password variable.

Would you like to exclude this secret from your status checks?
Tell us what to do with one of the following hashtags:

Tag Short Description
#cycode_secret_ignore_here Applies to this request only

@sebastianfdz
Copy link
Contributor Author

Git issues

@sebastianfdz sebastianfdz deleted the migrate/react-paypal-js branch June 7, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.