[DNM]: Add Rebranded PayPal Logo #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtjones404
reviewed
Feb 4, 2025
| @@ -123,6 +161,30 @@ export function PayPalLogoInlineSVG({ | |||
| ); | |||
| } | |||
|
|
|||
| export function PayPalRebrandLogoInlineSVG({ | |||
There was a problem hiding this comment.
Do we have any interest in serving the rebranded logo from CDN as well? In that case I think we'd need to create a PayPalRebrandedLogoExternalImage component, similar to PayPalLogoExternalImage.
There was a problem hiding this comment.
Yes, we do. I'm torn between creating a new component or adding a new "color" combo.
We are running an a/b test so if we create a new component we will add and delete it within 2-3 months.
Using the new "color", we could only include it for the version we release for the a/b test.
There was a problem hiding this comment.
Decided to go with a new logo component for the rebrand a/b test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.