target/loongarch/tcg/tlb_helper: fix ubsan with right shift

Found with functional test func-loongarch64-loongarch64_virt. ../target/loongarch/tcg/tlb_helper.c:470:31: runtime error: shift exponent 244 is too large for 64-bit type 'long unsigned int' #0 0x560036305470 in helper_invtlb_page_asid_or_g ../target/loongarch/tcg/tlb_helper.c:470 Signed-off-by: Pierrick Bouvier <[email protected]>
pbo-linaro · Jan 17, 2025 · 05f9d3b · 05f9d3b
1 parent fe6a26c
commit 05f9d3b
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/target/loongarch/tcg/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c
@@ -465,6 +465,7 @@ void helper_invtlb_page_asid_or_g(CPULoongArchState *env,
         tlb_vppn = FIELD_EX64(tlb->tlb_misc, TLB_MISC, VPPN);
         vpn = (addr & TARGET_VIRT_MASK) >> (tlb_ps + 1);
         compare_shift = tlb_ps + 1 - R_TLB_MISC_VPPN_SHIFT;
+        compare_shift = MIN(64, compare_shift);
 
         if ((tlb_g || (tlb_asid == asid)) &&
             (vpn == (tlb_vppn >> compare_shift))) {